Minor code cleanup and refactoring #172
Conversation
|
Hey @Bebra777228 , sorry I didn't get around to reviewing this (or your other PRs e.g. #175 ) sooner - I've just been really busy with my day job and other projects and didn't have any spoons left to spend on audio-separator. May I ask why you closed them? If it's just cos I was super slow to reply, would you be interested in being added as a maintainer of this repo instead? I suspect you have more free time than me 😅 |
|
Hey, no, it's not because of the slow response. I just decided to abandon the idea with the WebUI repository and move all the developments to HuggingFace. I deleted the audio-separator-UI repository, and with it, these PRs were also deleted. Should I try to restore everything in one PR, or would it be better to do it in separate ones? 🤔 As for adding me as a maintainer, it's up to you. I can't always review any provided changes from PRs and I'm not very proficient in the code yet, still learning. 😅 |
Code Cleanup and Refactoring
What was done:
Details:
test_cli_Vocals_output_name_argumentandtest_cli_Instrumental_output_name_argumentwere removed. This decision was made because the code already includes two tests for renaming all stems for Demucs and other architectures. Therefore, a separate test for individual stems was deemed redundant.test_cli_use_autocast_argumentwas also removed, as an identical test already exists in the code.test_inverse_device_handlingandtest_inverse_output_shapewere combined into a single function,test_inverse_stft, since they were performing the same action.